Fixed logo scaling

[regebro]

The logo would only scale on Chrome, and then it would scale wrongly if the viewport was big. I fixed this so it will be full size when the viewport > 610px and scale nicely when it's < 610px. Tested on Chromium 28, FF 22 and IE 10.

[RobZoneNet]

Lennart,

Hello how are you?

Line 34 of this file https://github.com/regebro/collective.responsivetheme/blob/2b6f4fd96e85a0d9776eaac4ad65d52b3eb9d68e/collective/responsivetheme/skins/collective_responsivetheme_styles/mediaqueries.css is causing the issue(300% width). I put all the mediaqueries in one file.

I see you took out the width out of logo.pt too.

Anyways I wouldn't mind correcting the mediaqueries.css. and not changing responsivetheme.css. Also for responsive it should be max-width: 100%; not width:100%; (only width:100% for older IE's). I could be ok with taking out the width out of logo.pt if you think that is hurting something.

What are your thoughts?

Rob

On Jul 8, 2013, at 3:00 AM, Lennart Regebro notifications@github.com wrote:

The logo would only scale on Chrome, and then it would scale wrongly if the viewport was big. I fixed this so it will be full size when the viewport > 610px and scale nicely when it's < 610px. Tested on Chromium 28, FF 22 and IE 10.

You can merge this Pull Request by running

git pull https://github.com/regebro/collective.responsivetheme master
Or view, comment on, or merge it at:

#2

Commit Summary

Fixed logo scaling.
File Changes

M collective/responsivetheme/skins/collective_responsivetheme_styles/responsivetheme.css (9)
M collective/responsivetheme/templates/plone.app.layout.viewlets.logo.pt (2)
Patch Links:

https://github.com/RobZoneNet/collective.responsivetheme/pull/2.patch
https://github.com/RobZoneNet/collective.responsivetheme/pull/2.diff

[regebro]

I mainly made a pull request because there was no issue tracker. :-) You fix the issue as you think is best.