Skip to content

Conversation

@SukkaW
Copy link

@SukkaW SukkaW commented Dec 24, 2025

Summary

Fixes #1041 by implementing #1041 (comment)

What kind of change does this PR introduce?

Moving filename and chunkFilename normalization into apply (because only then do we have access to the compiler object).

Now the precedence is:

this.options.filename -> compiler.options.output.cssFilename -> DEFAULT_FILENAME
this.options.chunkFilename -> compiler.options.output.cssChunkFilename -> getChunkFilenameFromFilename(filename)

Did you add tests for your changes?

Not yet, need help on where to add the test case. I am not familiar with the test folder structure here.

Does this PR introduce a breaking change?

No, by always preferring passed in filename and chunkFilename the breaking change could be avoided.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Maybe mention that we will also respect output.cssFilename and output.cssChunkFilename in existing options docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use output.cssFilename as default filename

1 participant