Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
/rebase |
0ea228f to
a8a9551
Compare
Member
Author
|
/rebase |
a8a9551 to
36213bc
Compare
Member
Author
|
/rebase |
Member
Author
|
/rebase |
1 similar comment
Member
Author
|
/rebase |
150e9b8 to
0628005
Compare
Member
Author
|
/rebase |
1690f89 to
4c2145f
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ults Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ton customization - Add Chinese storyName to all 7 existing stories for Storybook sidebar display - Add CustomTitle story: demonstrates TitleRender prop with status indicator - Add AsyncSubmit story: demonstrates confirmLoading + async onOk (success/failure) - Add ButtonCustomization story: demonstrates okButtonProps/cancelButtonProps (danger, disabled) - Remove unused G import from @src/utils/tower - Add cx import from @linaria/core for CustomTitle styling - Enhance JSDoc comments on all stories with usage context Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nd add SmallDialog Markdown - MediumDialog: add interface-level @description/@example/@see, enhance isContentFull docs - ImmersiveDialog: add interface-level JSDoc, document 3-panel layout, onOk signature difference - WizardDialog: add interface-level JSDoc, document onNextStep validation pattern, step behavior - SmallDialog: create Markdown doc with props table, usage patterns, and component recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…izardDialog - MediumDialog: add storyName to 8 stories, add SizeComparison story, add selection guide table in meta - ImmersiveDialog: add storyName to 6 stories, add TwoPanelLayout and FooterLeftAction stories, add meta description - WizardDialog: add storyName to 6 stories, add StepValidation story with onNextStep validation, add meta description Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…izardDialog - MediumDialog: 720px dialog with SmallDialog comparison table, isContentFull mode - ImmersiveDialog: full-screen dialog with three-panel layout docs, onOk signature warning - WizardDialog: multi-step wizard with onNextStep validation pattern, controlled mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- migration.md: LegacyModal to new Dialog components migration guide with props mapping, callback signature changes, and code examples - llms.txt: component index with 9 functional categories covering 100+ components - SKILL.md: Agent Skill for consumer-side usage with component selection guide Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- SKILL.md: 5 scenarios (doc enhancement, new component, Props sync, deprecation, doc audit) with shared rules and checklist - doc-workflow.md: 6-step executable flow (JSDoc → Storybook → Markdown → index → consumer skill → verify) - doc-template.md: Markdown doc template with section placeholders - deprecation-workflow.md: 5-step deprecation process Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Based on PR review feedback: - Restructure docs/ to match src/ layout (core/Component/guide.md) - Move migration guide into LegacyModal/migrate-guide.md - Remove Props tables from guide.md (type.ts JSDoc is authoritative) - Remove "组件选型" and "废弃清单" from consumer skill (already in llms.txt) - Add constraint JSDoc to WizardDialog/ImmersiveDialog type.ts - Remove redundant skill references and usage-patterns.md - Update dev skill templates and workflow accordingly Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Introduced DeleteDialog and RejectDialog components with comprehensive usage guides. - Updated llms.txt to reflect new dialog components and their features. - Enhanced .gitignore to include docs directory and evals under skills. - Added examples for asynchronous deletion and error handling in DeleteDialog. - Documented various rejection scenarios in RejectDialog, including single, all, and partial rejections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add agent-friendly JSDoc with examples to SearchInputProps, create guide.md with usage patterns, and update llms.txt index. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: liangyuyuyu <liangyuyuyu@users.noreply.github.com>
@storybook/react-vite auto-injects @vitejs/plugin-react (vite:react-*) which conflicts with @linaria/vite when processing .tsx files. The Babel transform in @vitejs/plugin-react re-generates code from AST, which can produce output with untransformed JSX. This causes es-module-lexer parse errors in Vite's build-import-analysis plugin during production builds. The fix: - Filter out vite:react-* plugins from Storybook's config - Use transformWithEsbuild as the sole JSX handler - Construct the final config directly instead of using mergeConfig Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add explicit "data-testid" prop to all core component types (no extends HTMLAttributes) - Simple components: explicit destructure + pass to root DOM element - Input components: ref callback to set testid on native input/textarea (bypassing antd wrapper) - Fields components: inject testid into input object for form field pattern - Composite components (Pagination, SmallDialog, ImmersiveDialog, WizardDialog, FailedLoad, etc.): derive sub-testids with prefix-suffix pattern - List components (Tab, Breadcrumb, DropdownMenu, LegacySelect): item-level testid support - Add data-testid reference guide and update SKILL.md - Update FieldsEnum snapshot tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ant Design Radio/Checkbox pass data-* attributes to the internal hidden <input>, but the change event is bound on the outer <label>. This causes E2E tests to fail when clicking the element found by data-testid. Use a marker ref pattern to set data-testid on the outer <label> instead, without adding visible DOM wrappers that could break RadioGroup/CheckboxGroup CSS selectors. Also: - Add yalc:publish script for local package publishing - Update cloudtower-eagle-dev skill: add TOC to add-testid.md, fix doc-template path, enhance description triggers, add decision tree Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: tanbowensg <tanbowensg@users.noreply.github.com>
c874b1f to
5bf80c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.