wip: support MS-COCO bbox field in read_coco#1284
Draft
jveitchmichaelis wants to merge 1 commit into
Draft
Conversation
jveitchmichaelis
changed the title
jveitchmichaelis
changed the title
jveitchmichaelis
force-pushed
the
coco_boxes
branch
from
eaaaab8 to
a7680b4
Compare
jveitchmichaelis
changed the title
ethanwhite
requested changes
May 8, 2026
Member
ethanwhite
left a comment
ethanwhite
left a comment
There was a problem hiding this comment.
This looks good to me other than one minor note on naming for clarity. That said the logs for the test failures have expired so I'm not sure if there's an issue there. I'd suggest rebasing on main with the name changes and we'll see what they test say.
Comment on lines
+445
to
+446
| # COCO bbox format is [x, y, width, height] | ||
| x, y, width, height = annotation["bbox"] |
Member
There was a problem hiding this comment.
Probably indicate that it's xmin and ymin for clarity
Collaborator
Author
|
I'll double check this against the new polygon dataset and recall why this is WIP... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for bounding box loading in
utilities.read_coco. Previously we assumed that MS-COCO files are for polygon labels, but as the linked issue correctly points out, bbox only is perfectly valid.This PR checks to see if the
segmentationkey is present, if not, loadbboxand convert to a shapely bbox instead. I've added an explicitbox/task argument for read_coco. Currently we only really support boxes, but in future I would add the same toread_fileto allow for the other tasks we're working on.Also adds a test case.
Tested with OAM-TCD (which has both formats):
Related Issue(s)
Fixes #1281
AI-Assisted Development
Autocomplete
AI tools used (if applicable):
Copilot in VS Code