Improve error message for missing normalization keys in normalize()#1364
Closed
Pritika2512 wants to merge 2 commits into
Closed
Improve error message for missing normalization keys in normalize()#1364Pritika2512 wants to merge 2 commits into
Pritika2512 wants to merge 2 commits into
Conversation
Author
|
Hi! This PR improves error clarity in normalize(). Happy to update if needed. |
Contributor
|
These changes have been included in PR #1365. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the error message in the
normalize()function when required keys are missing from the configuration.Changes
mean,std) are missingnorm_cfg) in the error output for better debuggingWhy this change?
The previous error message only listed missing keys, which could make debugging harder. Including the full configuration helps developers quickly identify issues in their input.
Impact