Skip to content

Multi server multi gpu#1367

Open
henrykironde wants to merge 5 commits into
weecology:mainfrom
henrykironde:multi-server-multi-gpu
Open

Multi server multi gpu#1367
henrykironde wants to merge 5 commits into
weecology:mainfrom
henrykironde:multi-server-multi-gpu

Conversation

@henrykironde
Copy link
Copy Markdown
Contributor

@henrykironde henrykironde commented Apr 3, 2026

Description

Related Issue(s)

AI-Assisted Development

  • I used AI tools (e.g., GitHub Copilot, ChatGPT, etc.) in developing this PR
  • I understand all the code I'm submitting
  • I have reviewed and validated all AI-generated code

AI tools used (if applicable):

Adds reproducible Slurm helpers for multinode
and large-tile prediction workflows.
Docs for multi-GPU and multi-node workflows.
@henrykironde henrykironde force-pushed the multi-server-multi-gpu branch 2 times, most recently from c609ac5 to 5f40515 Compare April 4, 2026 02:40
@henrykironde henrykironde force-pushed the multi-server-multi-gpu branch from 5f40515 to 0905ce4 Compare April 4, 2026 05:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 82.50000% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.53%. Comparing base (408e150) to head (b9c119c).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/deepforest/distributed.py 70.83% 14 Missing ⚠️
src/deepforest/main.py 80.64% 12 Missing ⚠️
src/deepforest/predict.py 76.19% 5 Missing ⚠️
src/deepforest/scripts/evaluate.py 71.42% 2 Missing ⚠️
src/deepforest/datasets/prediction.py 96.77% 1 Missing ⚠️
src/deepforest/scripts/train.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
- Coverage   86.87%   85.53%   -1.35%     
==========================================
  Files          24       25       +1     
  Lines        3064     3326     +262     
==========================================
+ Hits         2662     2845     +183     
- Misses        402      481      +79     
Flag Coverage Δ
unittests 85.53% <82.50%> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrykironde henrykironde force-pushed the multi-server-multi-gpu branch from 33ef29e to b9c119c Compare April 10, 2026 04:32
@henrykironde henrykironde marked this pull request as ready for review April 10, 2026 04:44
@bw4sz
Copy link
Copy Markdown
Collaborator

bw4sz commented Apr 10, 2026

Can you confirm what SLURM script you used to check this so i can match that?

Copy link
Copy Markdown
Collaborator

@bw4sz bw4sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to approve this, @jveitchmichaelis any objections? I have spoken to comet and they agree that the lack of multi-node GPU utilization graph is probably on their end and not anything wrong here.

@bw4sz
Copy link
Copy Markdown
Collaborator

bw4sz commented Apr 16, 2026

remove references to torchrun, we can use srun alone.

@bw4sz
Copy link
Copy Markdown
Collaborator

bw4sz commented Apr 16, 2026

To do, is @henrykironde comparing this with #1304 and decide if both are needing, but we want to get this done because it's broad and could make rebasing harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants