Skip to content

allow users to disable validate_coordinates#1375

Open
musaqlain wants to merge 1 commit into
weecology:mainfrom
musaqlain:disableValidation
Open

allow users to disable validate_coordinates#1375
musaqlain wants to merge 1 commit into
weecology:mainfrom
musaqlain:disableValidation

Conversation

@musaqlain
Copy link
Copy Markdown
Contributor

Resolves #1374

Question: Should I keep these tests or are these overhead?

#Ai usage
-I understand all the code I'm submitting
-I have reviewed and validated all AI-generated code

#Tool
Gemini

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.92%. Comparing base (408e150) to head (37b52e1).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   86.87%   86.92%   +0.04%     
==========================================
  Files          24       24              
  Lines        3064     3205     +141     
==========================================
+ Hits         2662     2786     +124     
- Misses        402      419      +17     
Flag Coverage Δ
unittests 86.92% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@musaqlain
Copy link
Copy Markdown
Contributor Author

there is no formatting issue in code, I think this 'pre-commit' error can be resolved by rerunning it----as it is saying error during build

@vickysharma-prog
Copy link
Copy Markdown
Contributor

Try commenting pre-commit.ci run. This will re-trigger the checks.

@ethanwhite
Copy link
Copy Markdown
Member

@musaqlain can you rebase this on main so that precommit will pass and then we'll try to get it reviewed

@ethanwhite ethanwhite added the Awaiting author contribution Waiting on the issue author to do something before proceeding label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting author contribution Waiting on the issue author to do something before proceeding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow option to turn off validate_coordinates at scale

3 participants