Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to lock the Docker image to a specific Python version (3.14) instead of using the floating python:3-slim tag. However, Python 3.14 does not exist yet - as of January 2025, the latest stable Python version is 3.13.x. This will cause the Docker build to fail when trying to pull the non-existent python:3.14-slim image.
Key Changes
- Updated Docker base image from
python:3-slimtopython:3.14-slim(non-existent version) - Updated volume mount path from
python3.xtopython3.14to match the specified Python version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
copilot says 3.14 doesn't exist yet. Weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Docker image to use Python 3.14 and adjust the volume path to reflect the new version.