fix(tempo): verify allowAccessKey for secp256k1 keychain#4596
Open
cmende wants to merge 1 commit into
Open
Conversation
|
|
@cmende is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR solving?
This PR fixes an incomplete
allowAccessKeyverification path intempoverifyHash.In the keychain branch, the current logic derives the access key address only from
envelope.inner.publicKey.For
secp256k1access keys, the inner envelope may not includepublicKey, which can cause thrown errors or false-negative verification for otherwise valid signatures.This change adds a fallback path:
envelope.inner.publicKeyexists, keep current behavior.envelope.inner.type === 'secp256k1', recover the access key address from the inner signature + payload.falseinstead of throwing.This preserves the existing metadata checks (authorized, not revoked, not expired) and only broadens support for valid
secp256k1keychain envelopes.Alternatives explored
publicKeyfor all key types in keychain envelopes.secp256k1envelope shape.verifyHash.allowAccessKeymode.publicKeysecp256k1inner signatures.Reviewer attention
Please focus on:
src/tempo/chainConfig.tsfor keychain +allowAccessKey.innerPayloadusage consistency for v1/v2 keychain envelopes.falsereturn instead of throw) in malformed/missing-key scenarios.Tests
Added:
accessKey: secp256k1 valid signatureinsrc/tempo/chainConfig.test.ts.The new test reproduces the previously unhandled
secp256k1keychain path and validates the fix.Docs
No public API changes. No docs update required.