fix(chains): correct Sova block explorer default URL#4599
Open
esorense wants to merge 1 commit into
Open
Conversation
|
@esorense is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR solving?
This PR fixes a typo in the Sova chain definition:
src/chains/definitions/sova.tsblockExplorers.default.urlwashhttps://explorer.sova.iohttps://explorer.sova.ioThis is a real correctness issue (not a design change).
The invalid scheme can break URL parsing and cause explorer-link checks/usages to fail.
Alternatives considered
Reviewer attention
Please focus on:
src/chains/definitions/sova.ts.Documentation impact
No documentation changes are required (no API or behavior contract changes beyond correcting bad data).
Tests
No new tests were added because existing coverage already validates explorer URLs in
test/scripts/chains.test.ts(blockExplorer.urlcheck).This change is intended to make Sova pass that existing path with a valid URL scheme.