Update guzzle and phpunit to latest version#16
Open
diego-sorribas wants to merge 2 commits intowgenial:masterfrom
Open
Update guzzle and phpunit to latest version#16diego-sorribas wants to merge 2 commits intowgenial:masterfrom
diego-sorribas wants to merge 2 commits intowgenial:masterfrom
Conversation
|
Any chance an update like this can get merged? Guzzle 7 is Laravel's default at the moment. |
Member
Yeap, I'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I needed to update guzzle to 7.0 to use it in my project and also I modified the constructor so it can accept a custom ArchiveOptions so I can set for example setSendHttpHeaders method. There is another option that is to pass an array and create the setters of ArchiveOptions inside de constructor.
I found very diffcult to test the constructor, inside s3Client method its makes a connection to S3 so without property key and secret its difficult to continue the flow.