selectedcontent post-connection steps did not break out of the loop #11878
Conversation
We don't use this ancestor variable. (The for each loop creates its own.)
annevk
changed the title
| @@ -59187,12 +59185,15 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s | |||
|
|
|||
| <li><p>Otherwise, set <var>selectedcontent</var>'s <span | |||
| data-x="selectedcontent-disabled">disabled</span> state to true.</p></li> | |||
There was a problem hiding this comment.
I think we should move the below break into this "otherwise" condition. If we always break when the ancestor is a select element, then we can't detect the nested select elements case.
There was a problem hiding this comment.
This is also what the chromium implementation does
There was a problem hiding this comment.
Good point, I think this is lacking test coverage.
There was a problem hiding this comment.
Although if we end up finding ourselves in a nested situation, why do we still run update select's selectedcontents on the innermost select?
There was a problem hiding this comment.
Good point, we should not run that in this case. Can we add a check for selectedcontent-disabled in the line which returns early when nearestAncestorSelect is null or has the multiple attribute?
Good point, I think this is lacking test coverage.
I am hoping that this is exhaustive enough: https://chromium-review.googlesource.com/c/chromium/src/+/7125591
And also has an unused ancestor variable.
/form-elements.html ( diff )