Skip to content

Init jPanel once…#1

Open
ghost wants to merge 1 commit intomasterfrom
Initialize-jPanel-once
Open

Init jPanel once…#1
ghost wants to merge 1 commit intomasterfrom
Initialize-jPanel-once

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 14, 2013

… by checking if the class jPanelMenu is there.

If not, we can run several times the init and create divs with the same ID.

… checking if the class jPanelMenu is there.
@jaschu
Copy link
Copy Markdown

jaschu commented May 16, 2013

I'm going to hold off on merging this in, for two reasons. One, you submitted this to the original plugin repo, which is great! I want to see what they do with it. Two, this actually goes against what I may be doing in another feature branch (or topic, to use the git terminology), where I want to be able to have two menu controls and two menus. (This is dependent on what one of our clients wants to do for their site. We're actually meeting about that today, so hopefully I'll have more info about that soon.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants