Override flavor sources in the given order#57
Open
Cazacu Tudor (cazacutudor) wants to merge 1 commit into
Open
Override flavor sources in the given order#57Cazacu Tudor (cazacutudor) wants to merge 1 commit into
Cazacu Tudor (cazacutudor) wants to merge 1 commit into
Conversation
Cazacu Tudor (cazacutudor)
requested review from
Nish Tahir (nishtahir),
Sam Heavner (slheavner) and
Matt VanNuys (vannuysm)
as code owners
Contributor
Sam Heavner (slheavner)
left a comment
Sam Heavner (slheavner)
left a comment
There was a problem hiding this comment.
Hey, sorry for the slow response!
I'm totally for this change, for some reason it made sense to me for reverse order, idk why 😆
Would you mind adding a configuration flag for backwards compatibility? It's fine if not reverse is the default
Contributor
Author
|
Hi Sam Heavner (@slheavner), i'm not sure why we still want to support the reversed version ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
If you have an flavor defined with 2 or more sources, they will be override in reverse direction those given. So source2 will be override by source1, what is confusing for the users.
This pull request will doing flavor source overrides in the given order.