Add lib folder to the list of published files in package#2
Open
haikov wants to merge 1 commit intowilmxre:mainfrom
Open
Add lib folder to the list of published files in package#2haikov wants to merge 1 commit intowilmxre:mainfrom
haikov wants to merge 1 commit intowilmxre:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, awesome work on the module, thank you!
This small PR addresses #1.
Currently published npm package doesn't include the
lib/folder, as you can see here https://www.npmjs.com/package/@wilmxre/react-native-mesh-gradient?activeTab=code, which makes the package unusable after installation.This is caused by
lib/folder missing from the list of files in package.json. I'm not sure at which point it dissapeared, since the template should've initially had it (see https://github.com/callstack/react-native-builder-bob/blob/main/packages/create-react-native-library/templates/common/%24package.json#L22).