Draft: Introduce rspec and retire minitest suite#8
Open
win93 wants to merge 5 commits intodevelopmentfrom
Open
Draft: Introduce rspec and retire minitest suite#8win93 wants to merge 5 commits intodevelopmentfrom
win93 wants to merge 5 commits intodevelopmentfrom
Conversation
Also in this commit I added a rubocop config since I am now making actually significant code changes. To that end, I've updated copyright headers for files I've added/touched, as well as run `rubocop -A` on them. This trend will continue as more files come into the fold.
win93
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of my actually substantial maintenance changes. This experience makes me want to drop ruby 2.5 and earlier soon.