migration: shuffle-property regression for sort tie-break#57
Merged
Conversation
PR #53 added the timestamp/id tie-break in migrations.compare. The existing 3-entry tests verify the contract but do not protect against a future refactor that introduces a comparator unstable under repeated hash-seeded shuffles. Two new tests permute the input 100 times via math.randomseed and assert the find() output is byte-identical: one covers the all-missing-timestamp case (the production symptom on Drew Altizer Keeper), and one covers mixed missing/tied/unique timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #53 fixed the timestamp/id tie-break in
migrations.compare. The existing 3-entry tests verify the contract but don't protect against a future refactor introducing a comparator that is unstable across hash-seeded shuffles.What
Two new tests permute the input 100 times via
math.randomseedand assertfind()output is byte-identical: