feat: export pems from credentials#2185
Open
coriolinus wants to merge 6 commits into
Open
Conversation
These methods already exist on `CredentialRef` and there's no point in redefining them; it's always simpler when there is exactly one way to accomplish some task.
This keeps credential-database stuff in one module, on one struct, which makes it easier to find and maintain. It simultaneously simplifies the `CoreCrypto` instance API.
For the amount of code it contains, it took a surprising amount of iteration to come up with the right way to do this.
This variant operates on a `CredentialRef` and is implemented on the `CoreCrypto` type instead of the `CredentialRef` type because it requires us to load the full credential from the database.
coriolinus
force-pushed
the
prgn/feat/export-pem
branch
from
96672fb to
20814b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.