Skip to content

feat: add feature toggle for incremental HTTP retry backoff [WPB-23381] #20629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
screendriver merged 1 commit into from
Mar 10, 2026
Merged

feat: add feature toggle for incremental HTTP retry backoff [WPB-23381] #20629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions apps/webapp/src/script/featureToggles/startupFeatureToggles.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ import {
startupFeatureToggleQueryParameterName,
} from './startupFeatureToggles';

describe('startupFeatureToggles', function () {
const reliableWebsocketConnectionFeatureToggleName = 'reliable-websocket-connection';
const reliableWebsocketConnectionFeatureToggleName = 'reliable-websocket-connection';
const incrementalHttpRetryBackoffFeatureToggleName = 'incremental-http-retry-backoff';

describe('startupFeatureToggles', function () {
it('returns disabled toggles when the query parameter is missing', function () {
const startupFeatureToggles = createStartupFeatureTogglesFromLocationSearch('?foo=bar');

Expand Down Expand Up @@ -58,6 +59,14 @@ describe('startupFeatureToggles', function () {
expect(startupFeatureToggles.getEnabledFeatureToggleNames()).toEqual([]);
});

it('enables the incremental http retry backoff feature toggle when present in the query parameter', function () {
const startupFeatureToggles = createStartupFeatureTogglesFromLocationSearch(
`?${startupFeatureToggleQueryParameterName}=${incrementalHttpRetryBackoffFeatureToggleName}`,
);

expect(startupFeatureToggles.isFeatureToggleEnabled(incrementalHttpRetryBackoffFeatureToggleName)).toBe(true);
});

it('keeps only whitelisted feature toggles when known and unknown values are mixed', function () {
const startupFeatureToggles = createStartupFeatureTogglesFromLocationSearch(
`?${startupFeatureToggleQueryParameterName}=unknown-feature,${reliableWebsocketConnectionFeatureToggleName}`,
Expand Down Expand Up @@ -106,7 +115,10 @@ describe('startupFeatureToggles', function () {
});

it('contains only whitelisted values in allowedStartupFeatureToggleNames', function () {
expect(allowedStartupFeatureToggleNames).toEqual([reliableWebsocketConnectionFeatureToggleName]);
expect(allowedStartupFeatureToggleNames).toEqual([
reliableWebsocketConnectionFeatureToggleName,
incrementalHttpRetryBackoffFeatureToggleName,
]);
});

it('does not expose mutable enabled toggle state', function () {
Expand Down
5 changes: 4 additions & 1 deletion apps/webapp/src/script/featureToggles/startupFeatureToggles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ import {Maybe} from 'true-myth';

export const startupFeatureToggleQueryParameterName = 'enabled-features';

export const allowedStartupFeatureToggleNames = ['reliable-websocket-connection'] as const;
export const allowedStartupFeatureToggleNames = [
'reliable-websocket-connection',
'incremental-http-retry-backoff',
] as const;

export type StartupFeatureToggleName = (typeof allowedStartupFeatureToggleNames)[number];

Expand Down