Skip to content

test: wait for message to arrive before searching for it [WPB-22420]#20634

Merged
markbrockhoff merged 1 commit intodevfrom
mb/de-flake-in-conversation-search-tests
Mar 11, 2026
Merged

test: wait for message to arrive before searching for it [WPB-22420]#20634
markbrockhoff merged 1 commit intodevfrom
mb/de-flake-in-conversation-search-tests

Conversation

@markbrockhoff
Copy link
Collaborator

@markbrockhoff markbrockhoff commented Mar 10, 2026

TaskWPB-22420 [Web] General maintenance ticket for PR merges

Pull Request

Summary

This should reduce some flake we're currently experiencing in some of the in conversation search tests


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

This should reduce some flake we're currently experiencing in some of the in conversation search tests
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 259
  • Failed: 1
  • Skipped: 15
  • 🔁 Flaky: 5
  • 📊 Total: 280
  • Total Runtime: 730.7s (~ 12 min 11 sec)
specs/Authentication/authentication.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/Conversations/conversations.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Conversations > I want to see a system message with all group members mentioned on creating a group (tags: TC-2965, regression)
specs/Edit/edit.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Edit > I want to see the last edited text including a timestamp in message detail view if the message has been edited (tags: TC-3563, regression)
specs/InConversationSearch/inConversationSearch.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ In Conversation Search > Verify results are sorted - latest message on top of list (tags: TC-398, regression)
specs/Notifications/notifications.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Notifications > No message content is written on notification when 'Show sender' item is selected in preferences (tags: TC-1451, regression)
specs/Status/status.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Status > I want to see a popup when I change my status (tags: TC-8772, regression)

@markbrockhoff markbrockhoff added this pull request to the merge queue Mar 11, 2026
Merged via the queue into dev with commit 641a4b6 Mar 11, 2026
84 of 85 checks passed
@markbrockhoff markbrockhoff deleted the mb/de-flake-in-conversation-search-tests branch March 11, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants