-
Notifications
You must be signed in to change notification settings - Fork 59
Fix/preview track changes improvements #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/preview track changes improvements #1131
Conversation
carla-at-wiris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
carla-at-wiris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Como se puede ver, el preview funciona bien cuando hay sugerencias con imagenes y texto intercalado, pero se rompe el getData(), lo que rompe el source y lo que muchos users usan; la combiancion de editor.setData(editor.getData())
Screencast from 2026-01-21 14-51-43.webm
ncornaglia-at-wiris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
carla-at-wiris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queda aprobada a sabiendas de que tenemos que contactar con el equipo de CK para gestionar el error que aparece a continuación:
- Cuando tenemos una fórmula al final modificada con el track changes
- Hacemos algunas otras modificaciones sencillas en el contenido del editor
- Validamos el source
- Hacemos un editor set Data de editor getData
- Borramos todo el contenido del editor
- Le damos a preview y se rompe como en la imagen


Description
This adds track changes suppor for mathml in source data and also adds a preview filtering for formulas
NOTE: the only file to review is plugin.js, utils.js, y parser.js
Type of Change
Checklist
yarn lintto check)How should be tested? (Manual or Automated Tests)
Manual tests: I have tested this changes manually.
Enter https://integrations.wiris.kitchen/feat/ck5-trackchanges-demo/html/ckeditor5/
Enable Track changes clicking on the icon
Edit a formula
View the source, track changes should be visible in the source