Closed
Conversation
- Introduced new alert states: STATE_OK, STATE_PRE_ALERT, STATE_ALERT, STATE_END. - Added configurable parameters for alert presets and idle timeout handling. - Updated polling logic to determine alert state based on received JSON data. - Removed deprecated alert rendering logic and replaced it with state-based updates. - Improved JSON configuration handling for new alert parameters.
- Introduced new alert state handling for STATE_OK and improved JSON parsing for alert categories. - Added support for additional alert presets and refined polling logic. - Updated platformio.ini to include WLED_DEBUG for enhanced debugging capabilities.
- Added support for an "all areas" mode, allowing alerts to be triggered regardless of specific city names. - Implemented area matching logic to compare city names against configured areas, improving alert accuracy. - Updated JSON handling to accommodate new area matching requirements and ensure proper state transitions based on alerts.
- Introduced a normalized area name to streamline area matching logic. - Updated area comparison to use the normalized name for improved accuracy. - Added a method to refresh the normalized area name when necessary. - Adjusted conditions to ensure proper handling of alerts based on the normalized area text.
- Introduced a new boolean parameter for verbose logging to enhance debugging capabilities. - Updated logging statements to conditionally print detailed information based on the verboseLogs setting. - Refactored JSON configuration handling to include the new verboseLogs parameter, ensuring it is properly saved and loaded.
- Introduced a new boolean parameter to enable or disable idle fallback handling. - Updated JSON configuration to include new pretty labels for core, area, states, and idle settings. - Refactored JSON loading and saving to maintain backward compatibility with legacy keys. - Improved clarity of code comments and structure for better maintainability.
- Changed area name from "תל אביב - מזרח" to "תל אביב - מרכז" for better accuracy. - Reduced default polling interval to 100 ms for more frequent updates. - Enabled pre-alert and end alerts by default to enhance notification capabilities. - Updated alert presets for better configuration options. - Added support for HTTPS requests using WiFiClientSecure, allowing secure communication with the alert API. - Implemented logic to handle potential non-JSON characters in API responses, improving robustness.
- Added logic to ignore alerts with category 0 or missing category, preventing unnecessary state changes. - Updated handling for category 10 to treat it as an end/clear state, alongside category 13. - Enhanced verbose logging for better debugging of ignored alerts based on category.
- Implemented logic to ignore alerts with category 0 or missing category, reducing unnecessary state changes. - Updated handling for category 10 to function as an end/clear state, in addition to category 13. - Enhanced verbose logging to improve debugging for ignored alerts based on category.
…unctionality - Updated the README to clarify HTTPS requirements and installation steps. - Added a section on live logging over WebSocket, detailing usermod and client-side implementation. - Removed the reset URL button and associated logic from the usermod, streamlining the code and improving maintainability.
- Updated alert state logic to differentiate between pre-alert and end states based on the API title for category 10. - Removed unused OK state handling and associated parameters to streamline the code. - Enhanced documentation in the README to reflect changes in alert state definitions and configurations.
- Updated the alert state handling to utilize raw JSON payloads for distinguishing between pre-alert and end states in category 10. - Introduced UTF-8 support for alert titles to improve compatibility with various payload formats. - Enhanced documentation in the README to clarify the changes in alert state definitions and the rationale behind the new implementation.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughAdds a new WLED usermod "redalert" (Pikud Haoref) with polling, area-matching, and preset switching; supporting utilities and docs. Also updates Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit