Skip to content

DMX Output - Runtime Config & replace SparkFunDMX with esp_dmx#5433

Draft
netmindz wants to merge 36 commits intowled:mainfrom
netmindz:dmx-output-esp_dmx
Draft

DMX Output - Runtime Config & replace SparkFunDMX with esp_dmx#5433
netmindz wants to merge 36 commits intowled:mainfrom
netmindz:dmx-output-esp_dmx

Conversation

@netmindz
Copy link
Member

@netmindz netmindz commented Mar 20, 2026

Allow the DMX Output pin to be set at runtime, not need the user to hack around in the source code
Also swap the DMX Output to the same driver as DMX Input, leaving only 8266 to use ESPDMX

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 70faa969-e409-4500-98b2-c6a1fa0f436c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Migrating from UI to YAML configuration.

Use the @coderabbitai configuration command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.

@netmindz netmindz added this to the 16.0.0 beta milestone Mar 20, 2026
HW_SPI = 0x8C, // 'SPI' == hardware (V)SPI pins (13,14&15 on ESP8266, 5,18&23 on ESP32)
DMX_INPUT = 0x8D, // 'DMX_INPUT' == DMX input via serial
HUB75 = 0x8E, // 'Hub75' == Hub75 driver
DMX_OUTPUT = 0x8F, // 'DMX_OUTPUT' == DMX output via serial
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: clean up

-D DECODE_LG=true
-DWLED_USE_MY_CONFIG
-D WLED_PS_DONT_REPLACE_FX ; PS replacement FX are purely a flash memory saving feature, do not replace classic FX until we run out of flash
-D WLED_ENABLE_DMX
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: remove before merge

@netmindz netmindz changed the title Dmx output esp dmx DMX Output - Runtime Config & replace SparkFunDMX with esp_dmx Mar 20, 2026
@netmindz netmindz modified the milestones: 16.0.0 beta, 16.1 Mar 20, 2026
@netmindz
Copy link
Member Author

Replaces corrupt #5287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant