Skip to content

03042026 Coverity tests fix #10129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlm2002 wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −6
Open

03042026 Coverity tests fix #10129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f59d50f
bound notBeforeDataEnd with origSz
rlm2002 Apr 3, 2026
5e79661
prevent resource leak if ASN1_INTEGER_to_BN() != null if expected
rlm2002 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/api/test_ossl_asn1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ int test_wolfSSL_ASN1_INTEGER_BN(void)
}
#if defined(WOLFSSL_QT) || defined(WOLFSSL_HAPROXY)
ExpectNotNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
BN_free(bn);
bn = NULL;
#else
ExpectNull(ASN1_INTEGER_to_BN(ai, NULL));
ExpectNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
#endif
BN_free(bn);
bn = NULL;

if (ai != NULL) {
ai->data[0] = 0x02; /* tag for ASN_INTEGER */
Expand All @@ -213,11 +213,11 @@ int test_wolfSSL_ASN1_INTEGER_BN(void)
#if defined(WOLFSSL_QT) || defined(WOLFSSL_HAPROXY)
/* Interpreted as a number 0x020403. */
ExpectNotNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
BN_free(bn);
bn = NULL;
#else
ExpectNull(ASN1_INTEGER_to_BN(ai, NULL));
ExpectNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
#endif
BN_free(bn);
bn = NULL;

if (ai != NULL) {
ai->data[0] = 0x02; /* tag for ASN_INTEGER */
Expand Down
3 changes: 3 additions & 0 deletions tests/api/test_x509.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,9 @@ static int craft_malicious_time_cert(const byte* orig, int origSz,

notBeforeLenOff = validityOff + 3; /* the 0x0D byte */
notBeforeDataEnd = notBeforeLenOff + 1 + 13; /* tag(1) was at +2, data starts at +4 */
if (notBeforeDataEnd >= origSz) {
return -1;
}

/* Build the new buffer:
* [0 .. notBeforeLenOff-1] unchanged prefix
Expand Down
Loading