Fix potential length mismatch in non realloc case in wolfSSL_BIO_set_conn_hostname.#10130
Open
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix potential length mismatch in non realloc case in wolfSSL_BIO_set_conn_hostname.#10130kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts a copy-length calculation to avoid a potential buffer read/length mismatch when resizing b->ip, based on an external report (zd#21528).
Changes:
- Updates the
XMEMCPYlength argument when copyingtmpinto a newly allocatedb->ipbuffer.
Comments suppressed due to low confidence (1)
src/bio.c:2231
- The PR title mentions fixing
wolfSSL_BIO_set_conn_hostname, but this diff changeswolfSSL_BIO_flush. If the fix is intended forwolfSSL_BIO_set_conn_hostname, the title/description should be updated to match the actual change, or the fix should be moved to the correct function so the PR is traceable to the reported issue.
int wolfSSL_BIO_flush(WOLFSSL_BIO* bio)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…conn_hostname. Thanks to Cal Page for the report.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Cal Page for the report.
Description
Partially fixes zd#21528
Testing
Built in tests
Checklist