Skip to content

Deduplicate code #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfadex merged 3 commits into from
Apr 1, 2026
Merged

Deduplicate code #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83bcd11
Deduplicate code
miniBill Mar 24, 2026
7376fec
Fix elm-review warnings
miniBill Apr 1, 2026
d5eb00c
Fix test
miniBill Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions review/suppressed/NoUnused.Exports.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 1, "filePath": "src/CliMonad.elm" },
{ "count": 1, "filePath": "src/OpenApi/Common/Internal.elm" }
]
}
19 changes: 0 additions & 19 deletions src/Common.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module Common exposing
, Package(..)
, RefTo
, RequestBody
, Response
, Schema
, Type(..)
, TypeName
Expand All @@ -22,7 +21,6 @@ module Common exposing
, moduleToNamespace
, parseRef
, parseRequestBodyRef
, parseResponseRef
, parseSchemaRef
, refTo
, refToString
Expand Down Expand Up @@ -481,10 +479,6 @@ type RequestBody
= TypeLevelRequestBody Never


type Response
= TypeLevelResponse Never


type BasicType
= Integer
| Boolean
Expand Down Expand Up @@ -582,19 +576,6 @@ parseRequestBodyRef ref =
)


parseResponseRef : String -> Result String (RefTo Response)
parseResponseRef ref =
parseRef ref
|> Result.andThen
(\(RefTo component res) ->
if component == Response then
Ok (RefTo Response res)

else
Err ("Expected a reference to a response, found a reference to " ++ ref)
)


unwrapUnsafe : UnsafeName -> String
unwrapUnsafe (UnsafeName name) =
name
Expand Down
Loading
Loading