Skip to content

test(ios): increase URLCache clear polling timeout for CI stability #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 1 commit into from
Apr 3, 2026
+6 −5
Merged

test(ios): increase URLCache clear polling timeout for CI stability #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ios/Tests/GutenbergKitTests/Stores/EditorURLCacheTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ struct EditorURLCacheTests {

// MARK: - clear()

@Test("clear removes all entries")
@Test("clear removes all entries", .timeLimit(.minutes(1)))
func clearRemovesAll() throws {
try cache.store(makeResponse(), for: testURL, httpMethod: .GET)
let otherURL = URL(string: "https://example.com/other")!
Expand All @@ -155,7 +155,7 @@ struct EditorURLCacheTests {
#expect(try cache.response(for: otherURL, httpMethod: .GET) == nil)
}

@Test("store succeeds after clear")
@Test("store succeeds after clear", .timeLimit(.minutes(1)))
func storeAfterClear() throws {
try cache.store(makeResponse(), for: testURL, httpMethod: .GET)
try cache.clear()
Expand All @@ -169,13 +169,14 @@ struct EditorURLCacheTests {

/// Polls until `URLCache.removeAllCachedResponses()` has taken effect.
///
/// Uses exponential backoff (0.05s, 0.1s, 0.2s, 0.4s, ...) with a 1s total timeout.
/// Uses exponential backoff (0.05s, 0.1s, 0.2s, 0.4s, ...) with a 5s total timeout.
/// `URLCache` clears asynchronously, so the in-memory layer may still serve
/// stale entries for a short window after `clear()` returns.
/// stale entries for a short window after `clear()` returns. CI environments
/// with slower I/O may need the longer timeout.
private func waitForClearToTakeEffect(cache: EditorURLCache, url: URL) throws {
var delay: TimeInterval = 0.05
var elapsed: TimeInterval = 0
while elapsed < 1.0 {
while elapsed < 5.0 {
guard try cache.response(for: url, httpMethod: .GET) != nil else { return }
Thread.sleep(forTimeInterval: delay)
elapsed += delay
Expand Down
Loading