-
Notifications
You must be signed in to change notification settings - Fork 3
fix: normalize data store attributes to plain strings in JS bridge #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jkmassel
wants to merge
2
commits into
trunk
Choose a base branch
from
jkmassel/fix-title-object-unwrap
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import EditorPage from './editor-page'; | ||
|
|
||
| test.describe( 'getTitleAndContent', () => { | ||
| test( 'returns correct title and content before any edits', async ( { | ||
| page, | ||
| } ) => { | ||
| const editor = new EditorPage( page ); | ||
| await editor.setup( { | ||
| post: { | ||
| id: 1, | ||
| type: 'post', | ||
| status: 'draft', | ||
| title: 'Initial Title', | ||
| content: | ||
| '<!-- wp:paragraph -->\n<p>Hello</p>\n<!-- /wp:paragraph -->', | ||
| }, | ||
| } ); | ||
|
|
||
| const result = await editor.getTitleAndContent(); | ||
|
|
||
| expect( typeof result.title ).toBe( 'string' ); | ||
| expect( typeof result.content ).toBe( 'string' ); | ||
| expect( result.title ).toBe( 'Initial Title' ); | ||
| expect( result.content ).toBe( | ||
| '<!-- wp:paragraph -->\n<p>Hello</p>\n<!-- /wp:paragraph -->' | ||
| ); | ||
| expect( result.changed ).toBe( false ); | ||
| } ); | ||
|
|
||
| test( 'returns plain strings after editing the title', async ( { | ||
| page, | ||
| } ) => { | ||
| const editor = new EditorPage( page ); | ||
| await editor.setup( { | ||
| post: { | ||
| id: 1, | ||
| type: 'post', | ||
| status: 'draft', | ||
| title: 'Original', | ||
| content: '', | ||
| }, | ||
| } ); | ||
|
|
||
| const titleInput = page.getByRole( 'textbox', { | ||
| name: 'Add title', | ||
| } ); | ||
| await titleInput.click(); | ||
| await page.keyboard.press( 'ControlOrMeta+a' ); | ||
| await page.keyboard.type( 'Updated Title' ); | ||
|
|
||
| const result = await editor.getTitleAndContent(); | ||
|
|
||
| expect( typeof result.title ).toBe( 'string' ); | ||
| expect( result.title ).toBe( 'Updated Title' ); | ||
| expect( result.changed ).toBe( true ); | ||
| } ); | ||
|
|
||
| test( 'returns plain strings after editing content', async ( { page } ) => { | ||
| const editor = new EditorPage( page ); | ||
| await editor.setup( { | ||
| post: { | ||
| id: 1, | ||
| type: 'post', | ||
| status: 'draft', | ||
| title: 'Title', | ||
| content: '', | ||
| }, | ||
| } ); | ||
|
|
||
| await editor.clickBlockAppender(); | ||
| await page.keyboard.type( 'New paragraph' ); | ||
|
|
||
| const result = await editor.getTitleAndContent(); | ||
|
|
||
| expect( typeof result.title ).toBe( 'string' ); | ||
| expect( typeof result.content ).toBe( 'string' ); | ||
| expect( result.title ).toBe( 'Title' ); | ||
| expect( result.content ).toContain( 'New paragraph' ); | ||
| expect( result.changed ).toBe( true ); | ||
| } ); | ||
|
|
||
| test( 'returns plain strings with empty initial state', async ( { | ||
| page, | ||
| } ) => { | ||
| const editor = new EditorPage( page ); | ||
| await editor.setup(); | ||
|
|
||
| const result = await editor.getTitleAndContent(); | ||
|
|
||
| expect( typeof result.title ).toBe( 'string' ); | ||
| expect( typeof result.content ).toBe( 'string' ); | ||
| expect( result.title ).toBe( '' ); | ||
| expect( result.content ).toBe( '' ); | ||
| expect( result.changed ).toBe( false ); | ||
| } ); | ||
|
|
||
| test( 'returns plain strings when data store title is a {raw, rendered} object', async ( { | ||
| page, | ||
| } ) => { | ||
| const editor = new EditorPage( page ); | ||
| await editor.setup( { | ||
| post: { | ||
| id: 1, | ||
| type: 'post', | ||
| status: 'draft', | ||
| title: 'Initial Title', | ||
| content: '', | ||
| }, | ||
| } ); | ||
|
|
||
| // Inject an object-shaped title edit via editEntityRecord. | ||
| // This simulates the Gutenberg data store bug where | ||
| // getEditedPostAttribute bypasses getPostRawValue normalization | ||
| // for values in the edits layer. | ||
| await page.evaluate( () => { | ||
| window.wp.data | ||
| .dispatch( 'core' ) | ||
| .editEntityRecord( 'postType', 'post', 1, { | ||
| title: { | ||
| raw: 'Object Title', | ||
| rendered: '<b>Object Title</b>', | ||
| }, | ||
| } ); | ||
| } ); | ||
|
|
||
| const result = await editor.getTitleAndContent(); | ||
|
|
||
| expect( typeof result.title ).toBe( 'string' ); | ||
| expect( result.title ).toBe( 'Object Title' ); | ||
| expect( result.changed ).toBe( true ); | ||
|
|
||
| // Second call should report no further changes. | ||
| const second = await editor.getTitleAndContent(); | ||
| expect( second.changed ).toBe( false ); | ||
| } ); | ||
|
|
||
| test( 'returns plain strings when data store content is a {raw, rendered} object', async ( { | ||
| page, | ||
| } ) => { | ||
| const editor = new EditorPage( page ); | ||
| await editor.setup( { | ||
| post: { | ||
| id: 1, | ||
| type: 'post', | ||
| status: 'draft', | ||
| title: 'Title', | ||
| content: '', | ||
| }, | ||
| } ); | ||
|
|
||
| await page.evaluate( () => { | ||
| window.wp.data | ||
| .dispatch( 'core' ) | ||
| .editEntityRecord( 'postType', 'post', 1, { | ||
| content: { | ||
| raw: '<!-- wp:paragraph --><p>Test</p><!-- /wp:paragraph -->', | ||
| rendered: '<p>Test</p>', | ||
| }, | ||
| } ); | ||
| } ); | ||
|
|
||
| const result = await editor.getTitleAndContent(); | ||
|
|
||
| expect( typeof result.content ).toBe( 'string' ); | ||
| expect( result.content ).toContain( | ||
| '<!-- wp:paragraph --><p>Test</p><!-- /wp:paragraph -->' | ||
| ); | ||
| expect( result.changed ).toBe( true ); | ||
|
|
||
| // Second call should report no further changes. | ||
| const second = await editor.getTitleAndContent(); | ||
| expect( second.changed ).toBe( false ); | ||
| } ); | ||
| } ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears there is one location using this method that we need to update: the unused comment editor.