Parallelize CI lint jobs and switch to Debug variant

.buildkite/commands/lint.sh

@@ -6,28 +6,39 @@ fi
 
 "$(dirname "${BASH_SOURCE[0]}")/restore-cache.sh"
 
-echo "--- :rubygems: Setting up Gems"
-install_gems
-
-echo "--- :globe_with_meridians: Check Locales Declaration Consistency"
-bundle exec fastlane check_declared_locales_consistency app:"$1"
+# Use Debug for PR builds (faster), Release for trunk and release-branch builds.
+# PRs targeting a release branch use Release to catch release-only issues before merge.
+if [[ "${BUILDKITE_PULL_REQUEST:-false}" != "false" && "${BUILDKITE_PULL_REQUEST_BASE_BRANCH:-}" =~ ^release/ ]]; then
+  BUILD_VARIANT="Release"
+elif [ "${BUILDKITE_PULL_REQUEST:-false}" != "false" ]; then
+  BUILD_VARIANT="Debug"
+else
+  BUILD_VARIANT="Release"
+fi
 
-echo "--- :microscope: Linting"
+echo "--- :microscope: Linting (${BUILD_VARIANT})"
 
 if [ "$1" = "wordpress" ]; then
-  ./gradlew lintWordpressRelease
+  ./gradlew lintWordpress"${BUILD_VARIANT}"
   exit 0
 fi
 
 if [ "$1" = "jetpack" ]; then
   set +e
-  ./gradlew lintJetpackRelease
+  ./gradlew lintJetpack"${BUILD_VARIANT}"
   lint_exit_code=$?
   set -e
 
-  upload_sarif_to_github "WordPress/build/reports/lint-results-jetpackRelease.sarif"
+  upload_sarif_to_github "WordPress/build/reports/lint-results-jetpack${BUILD_VARIANT}.sarif"
   exit $lint_exit_code
 fi
 
+if [ "$1" = "library" ]; then
+  ./gradlew \
+    :libs:editor:lint"${BUILD_VARIANT}" \
+    :libs:image-editor:lint"${BUILD_VARIANT}"
+  exit 0
+fi
+
 echo "No target provided – unable to lint"
 exit 1

.buildkite/pipeline.yml

@@ -59,17 +59,46 @@ steps:
         artifact_paths:
           - "**/build/reports/detekt/detekt.html"
 
+      - label: "🌐 Locale Consistency"
+        command: |
+          if .buildkite/commands/should-skip-job.sh --job-type validation; then
+            exit 0
+          fi
+
+          install_gems
+          bundle exec fastlane check_declared_locales_consistency app:wordpress
+          bundle exec fastlane check_declared_locales_consistency app:jetpack
+        plugins: [$CI_TOOLKIT]
+
       - label: "🕵️ Lint WordPress"
         command: ".buildkite/commands/lint.sh wordpress"
         plugins: [$CI_TOOLKIT]
         artifact_paths:
           - "**/build/reports/lint-results*.*"
+        notify:
+          - slack:
+              channels:
+                - "#wpmobile-team"
+              message: "⚠️ Lint WordPress failed on trunk."
+            if: build.pull_request.id == null && step.outcome != "passed"
 
       - label: "🕵️ Lint Jetpack"
         command: ".buildkite/commands/lint.sh jetpack"
         plugins: [$CI_TOOLKIT]
         artifact_paths:
           - "**/build/reports/lint-results*.*"
+        notify:
+          - slack:
+              channels:
+                - "#wpmobile-team"
+              message: "⚠️ Lint Jetpack failed on trunk."
+            if: build.pull_request.id == null && step.outcome != "passed"
+
+      - label: "🕵️ Lint Libraries"
+        command: ".buildkite/commands/lint.sh library"
+        plugins: [$CI_TOOLKIT]
+        artifact_paths:
+          - "**/build/reports/lint-results*.*"
 
   #################
   # Diff Reports

build.gradle

@@ -99,7 +99,7 @@ subprojects {
         android {
             lint {
                 warningsAsErrors = true
-                checkDependencies true
+                checkDependencies false
                 checkGeneratedSources = true
                 lintConfig file("${project.rootDir}/config/lint/lint.xml")
                 baseline file("${project.rootDir}/config/lint/baseline.xml")