Skip to content

Remove WordPress uninstall card from Jetpack dashboard#22761

Draft
jkmassel wants to merge 1 commit intotrunkfrom
jkmassel/fix-wp-uninstall-card
Draft

Remove WordPress uninstall card from Jetpack dashboard#22761
jkmassel wants to merge 1 commit intotrunkfrom
jkmassel/fix-wp-uninstall-card

Conversation

@jkmassel
Copy link
Copy Markdown
Contributor

@jkmassel jkmassel commented Apr 3, 2026

Summary

  • Removes the "Welcome to the Jetpack app. You can uninstall the WordPress app" dashboard card that was incorrectly shown in Jetpack even when WordPress was not installed
  • Removes the associated "Please Delete WordPress" screen, navigation action, analytics tracking, drawables, and translated strings
  • Adds a 9-param merge() overload to LiveDataUtils (needed after removing the migration card source from the 10-source dashboard merge)

Fixes: CMM-2004

Test plan

  • Install Jetpack debug build and verify the uninstall card no longer appears on the dashboard
  • Verify the migration flow (Welcome → Notifications → Done) still works when triggered from a fresh Jetpack install
  • Verify no build warnings or test failures

🤖 Generated with Claude Code

@dangermattic
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@jkmassel jkmassel force-pushed the jkmassel/fix-wp-uninstall-card branch from 2fa2f1d to c0b0282 Compare April 3, 2026 04:13
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Apr 3, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr22761-d5fb601
Build Number1488
Application IDcom.jetpack.android.prealpha
Commitd5fb601
Installation URL6dml9isbvvrfo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Apr 3, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr22761-d5fb601
Build Number1488
Application IDorg.wordpress.android.prealpha
Commitd5fb601
Installation URL70n53ong2fc78
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 65.38462% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.36%. Comparing base (8c0b6d4) to head (d5fb601).

Files with missing lines Patch % Lines
...n/java/org/wordpress/android/util/LiveDataUtils.kt 65.38% 0 Missing and 18 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #22761      +/-   ##
==========================================
- Coverage   37.40%   37.36%   -0.04%     
==========================================
  Files        2320     2319       -1     
  Lines      123674   123662      -12     
  Branches    16791    16804      +13     
==========================================
- Hits        46256    46207      -49     
- Misses      73707    73727      +20     
- Partials     3711     3728      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkmassel jkmassel force-pushed the jkmassel/fix-wp-uninstall-card branch from c0b0282 to 5b631b4 Compare April 3, 2026 20:18
@wordpress-mobile wordpress-mobile deleted a comment from sonarqubecloud bot Apr 3, 2026
The "Welcome to the Jetpack app. You can uninstall the WordPress app"
card was showing incorrectly even when WordPress was not installed,
confusing users. Remove the card entirely along with the associated
"Please Delete WordPress" screen, analytics tracking, navigation
action, drawables, and translated strings.

Fixes: CMM-2004

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkmassel jkmassel force-pushed the jkmassel/fix-wp-uninstall-card branch from 5b631b4 to d5fb601 Compare April 3, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants