Skip to content

Fix Form 8-K metadata always loaded and add accession_number index #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sroussey merged 2 commits into from
Mar 8, 2026
Merged

Fix Form 8-K metadata always loaded and add accession_number index #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a25d980
Initial plan
Copilot Mar 7, 2026
72ad6d2
Fix Form 8-K metadata loading and add accession_number index
Copilot Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/config/DefaultDI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ export const DefaultDI = () => {
createStorage("form_8k_events", Form8KEventSchema, Form8KEventPrimaryKeyNames, [
["cik", "filing_date"],
["item_code"],
["cik", "accession_number"],
])
);
};
1 change: 1 addition & 0 deletions src/config/TestingDI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ export function resetDependencyInjectionsForTesting() {
new InMemoryTabularStorage(Form8KEventSchema, Form8KEventPrimaryKeyNames, [
["cik", "filing_date"],
["item_code"],
["cik", "accession_number"],
])
);
}
24 changes: 11 additions & 13 deletions src/task/forms/ProcessAccessionDocFormTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,17 @@ export class ProcessAccessionDocFormTask extends Task<
let items: string | null | undefined;
let report_date: string | null | undefined;

if (!cik || !form || !fileName) {
const filingRepo = globalServiceRegistry.get(FILING_REPOSITORY_TOKEN);
const filings = await filingRepo.query({ accession_number: accessionNumber });
const filing = filings?.[0];
if (!filing) throw new TaskError("Filing not found");
cik = filing.cik;
form = filing.form ?? undefined;
filing_date = filing.filing_date;
file_number = filing.file_number;
items = filing.items;
report_date = filing.report_date;
fileName = fileName ?? filing.primary_doc;
}
const filingRepo = globalServiceRegistry.get(FILING_REPOSITORY_TOKEN);
const filings = await filingRepo.query({ accession_number: accessionNumber });
const filing = filings?.[0];
if (!filing) throw new TaskError("Filing not found");
if (!cik) cik = filing.cik;
if (!form) form = filing.form ?? undefined;
filing_date = filing.filing_date;
file_number = filing.file_number;
items = filing.items;
report_date = filing.report_date;
if (!fileName) fileName = filing.primary_doc;

if (!form) {
throw new TaskError(`Filing ${accessionNumber} has no form type`);
Expand Down