Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecfc4d1284
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd2789ad57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@cursor review |
|
Thanks for the Review @AlexKaravaev ! I will merge after I test the binary:
|
This pull request introduces a new mechanism for selecting operator default colors based on the current release type (such as "Analysis" or "Prod") for both Pearl and Diamond orb types. It achieves this by reading the OS release type at runtime and updating the logic throughout the codebase to use the appropriate color constants. Additionally, new color constants specific to the "Analysis" release type are added.
Release-type aware color selection:
RELEASE_TYPE(usingLazyLock) inui/src/main.rsthat reads the currentOrbReleasefrom/etc/os-release, defaulting toProdif unavailable.pearl_operator_default()anddiamond_operator_default()inui/src/engine/mod.rsto select the correct color constant based onRELEASE_TYPE.PEARL_OPERATOR_DEFAULTandDIAMOND_OPERATOR_DEFAULTin operator logic (idle, pulse, signup_phase, and runner modules) to use the new helper functions, ensuring color selection is dynamic based on release type. [1] [2] [3] [4] [5] [6]New color constants:
PEARL_OPERATOR_ANALYSISandDIAMOND_OPERATOR_ANALYSIScolor constants to theArgbimplementation for use in the "Analysis" release type. [1] [2]Dependency and import updates:
once_celland updatedorb-infodependencies inui/Cargo.tomlto support the new static initialization.ui/src/engine/mod.rsandui/src/main.rsto includeorb_info::orb_os_release::{OrbOsRelease, OrbRelease}and related types. [1] [2]