Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's dependency on WP-CLI to version 2.13, ensuring compatibility with the latest features and improvements. Concurrently, it refines the static analysis setup using PHPStan by including a new scan file and recognizing a critical global constant, which helps in catching potential issues earlier and maintaining code quality. These changes collectively enhance the development environment's robustness and accuracy. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR updates the package to require WP-CLI v2.13 and adjusts static-analysis configuration to accommodate WordPress-specific globals/constants during PHPStan runs.
Changes:
- Bump
wp-cli/wp-clidependency from^2.12to^2.13. - Add a PHPStan scan file that defines
ABSPATH, and update PHPStan config to recognize it. - Update code comments/config to align with the new tooling expectations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
composer.json |
Raises the minimum required WP-CLI version to ^2.13. |
phpstan.neon.dist |
Loads a scan file and configures handling for ABSPATH during analysis. |
tests/phpstan/scan-files.php |
Defines ABSPATH for PHPStan’s reflection/analysis context. |
phpcs.xml.dist |
Attempts to exclude the PHPStan scan file from PHPCS scanning. |
src/Role_Command.php |
Removes @throws annotation from persistence_check() docblock. |
src/Capabilities_Command.php |
Removes @throws annotation from persistence_check() docblock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <exclude-pattern>*/src/(Role|Capabilities)_Command\.php$</exclude-pattern> | ||
| </rule> | ||
|
|
||
| <exclude-pattern>/tests/phpstan/scan-files</exclude-pattern> |
There was a problem hiding this comment.
phpcs.xml.dist exclude pattern likely won’t match tests/phpstan/scan-files.php because it starts with a leading / (paths are typically relative to the ruleset basepath) and doesn’t include the .php suffix. Update the pattern to match the actual file path (e.g., use a wildcard prefix like */ and include/anchor the .php extension) so PHPCS reliably excludes this bootstrap file.
| <exclude-pattern>/tests/phpstan/scan-files</exclude-pattern> | |
| <exclude-pattern>*/tests/phpstan/scan-files\.php$</exclude-pattern> |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the wp-cli/wp-cli dependency to ^2.13 and refines the PHPStan and PHPCS configurations. It adds tests/phpstan/scan-files.php to PHPStan's scanned files and defines ABSPATH as a dynamic constant. Additionally, unnecessary @throws tags are removed from docblocks in Capabilities_Command.php and Role_Command.php. A review comment points out that the newly added exclude-pattern in phpcs.xml.dist is incorrectly formatted and will not effectively exclude the intended files.
| <exclude-pattern>*/src/(Role|Capabilities)_Command\.php$</exclude-pattern> | ||
| </rule> | ||
|
|
||
| <exclude-pattern>/tests/phpstan/scan-files</exclude-pattern> |
There was a problem hiding this comment.
The regular expression for the exclude-pattern seems incorrect. With basepath set to ./, file paths are relative (e.g., tests/phpstan/scan-files.php). The leading slash in /tests/phpstan/scan-files will prevent it from matching this path.
To correctly exclude the new file, you should remove the leading slash and consider making the pattern more specific to avoid unintended matches, similar to other patterns in this file.
<exclude-pattern>tests/phpstan/scan-files\.php$</exclude-pattern>
No description provided.