Skip to content

Revert "Setup & teardown hardening"#321

Merged
swissspidy merged 1 commit intomainfrom
revert-320-fix-cleanup-os
Mar 24, 2026
Merged

Revert "Setup & teardown hardening"#321
swissspidy merged 1 commit intomainfrom
revert-320-fix-cleanup-os

Conversation

@swissspidy
Copy link
Member

Reverts #320

This should be handled by the framework instead.

@swissspidy swissspidy added this to the 5.1.4 milestone Mar 24, 2026
@swissspidy swissspidy requested a review from a team as a code owner March 24, 2026 11:34
Copilot AI review requested due to automatic review settings March 24, 2026 11:34
@github-actions
Copy link
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the testing environment setup by reverting a previous change that added the WP_CLI_SKIP_PROMPT environment variable. The decision to revert is based on the principle that the testing framework should handle such configurations, ensuring a cleaner and more consistent test execution process.

Highlights

  • Reverted Previous Hardening: This pull request reverts the changes introduced in wp-cli/wp-cli-tests#320, specifically removing the WP_CLI_SKIP_PROMPT environment variable from the test setup.
  • Framework Responsibility: The rationale for this revert is that such hardening and environment configuration should be managed by the testing framework itself, rather than being explicitly set in the test context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Context/FeatureContext.php 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change that added the WP_CLI_SKIP_PROMPT environment variable to the test process setup. The removal is justified as this configuration is better handled by the framework. The code change is correct and limited to this revert.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a prior “setup & teardown hardening” change so that prompt-skipping behavior is no longer forced by the test harness and can instead be handled by the underlying framework.

Changes:

  • Removes the explicit WP_CLI_SKIP_PROMPT environment override from the spawned wp process environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit c805664 into main Mar 24, 2026
83 checks passed
@swissspidy swissspidy deleted the revert-320-fix-cleanup-os branch March 24, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants