Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Behat tag, @skip-object-cache, to explicitly mark tests that should be skipped when the WP_CLI_TEST_OBJECT_CACHE environment variable is set to 'sqlite'. This change is consistently applied across multiple test methods in tests/tests/TestBehatTags.php and in the utils/behat-tags.php utility script. There is no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR extends the Behat tag filtering script to support skipping scenarios when a persistent object cache is enabled (currently via the SQLite object cache backend), and updates the PHPUnit expectations accordingly.
Changes:
- Add
@skip-object-cacheto the generated skip tag list whenWP_CLI_TEST_OBJECT_CACHE=sqlite. - Update
TestBehatTagsexpectations to include~@skip-object-cachein object-cache-enabled environments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utils/behat-tags.php | Adds conditional skip tag generation for @skip-object-cache when SQLite object cache is enabled. |
| tests/tests/TestBehatTags.php | Updates multiple assertions to match the new tag filtering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.