bug fix for particle with periodic condition#345
Merged
mathrack merged 6 commits intoxcompact3d:masterfrom Mar 20, 2025
Merged
Conversation
mathrack
reviewed
Mar 11, 2025
mathrack
previously approved these changes
Mar 12, 2025
pbartholomew08
requested changes
Mar 20, 2025
src/particle.f90
Outdated
| ! local data | ||
| real(mytype) :: iface | ||
| real(mytype),save :: bcord(6) | ||
| real(mytype),save :: bcord(6),lenpe(6) |
Member
There was a problem hiding this comment.
For consistency with the rest of the code this should be
real(mytype), dimension(6), save :: bcord, lenpe
Comment on lines
+2103
to
+2108
| lenpe(1)=xlx | ||
| lenpe(2)=-xlx | ||
| lenpe(3)=yly | ||
| lenpe(4)=-yly | ||
| lenpe(5)=zlz | ||
| lenpe(6)=-zlz |
Member
There was a problem hiding this comment.
Why is the length being defined as 2xL in each direction?
Member
There was a problem hiding this comment.
perhaps add a comment to explain this
pbartholomew08
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implemetation of particle periodic condition is wrong. particles would be still out of the domain.
the bug is fixed