Merged
Conversation
15g-lucas
requested changes
Oct 21, 2025
src/Extensions/InternetExtension.php
Outdated
| } | ||
| } | ||
|
|
||
| return sprintf('http%s://%s%s', $secure ? 's': '', $url, $this->domain()); |
Contributor
There was a problem hiding this comment.
I think your function generates URLs from: https://example/second/one.example.com
That's not correct.
Contributor
Author
There was a problem hiding this comment.
I don't understand what you mean.
Contributor
|
Can you fix style CI here? :) |
martinsoenen
requested changes
Nov 18, 2025
Contributor
martinsoenen
left a comment
martinsoenen
left a comment
There was a problem hiding this comment.
Geat idea but can be upgraded :)
src/Extensions/InternetExtension.php
Outdated
Comment on lines
+59
to
+66
| $generateLetter = function (): string { | ||
| return $this->randomizer->getBytesFromString( | ||
| implode(range('a', 'z')), | ||
| $this->randomizer->getInt(4, 30) | ||
| ); | ||
| }; | ||
|
|
||
| $url = $generateLetter(); |
Contributor
There was a problem hiding this comment.
The idea is great but please use existing Faker functions like domain()
martinsoenen
approved these changes
Nov 18, 2025
Contributor
martinsoenen
left a comment
martinsoenen
left a comment
There was a problem hiding this comment.
Good for me. @15g-lucas ?
Contributor
|
Let's go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate random url
closes #70