Skip to content

PHP 8.5 compatibility#76

Merged
martinsoenen merged 6 commits intomainfrom
php8.5-compatibility
Mar 9, 2026
Merged

PHP 8.5 compatibility#76
martinsoenen merged 6 commits intomainfrom
php8.5-compatibility

Conversation

@martinsoenen
Copy link
Contributor

@martinsoenen martinsoenen commented Feb 5, 2026

Add PHP 8.5 tests
Fix deprecations in 8.5 (about "null" as an array offset https://www.php.net/manual/en/migration85.deprecated.php)

@martinsoenen martinsoenen changed the title PHP8.5 compatibility Draft: PHP8.5 compatibility Feb 5, 2026
@martinsoenen martinsoenen changed the title Draft: PHP8.5 compatibility PHP8.5 compatibility Feb 5, 2026
@martinsoenen martinsoenen changed the title PHP8.5 compatibility PHP 8.5 compatibility Feb 5, 2026
@martinsoenen martinsoenen requested a review from GautierDele March 8, 2026 14:54
@GautierDele
Copy link
Member

LGTM ! Can you just please force the PHP version we support in the composer.json file ?
https://github.com/xefi/faker-php/blob/main/composer.json#L21

If PHP upgrades but breaks our codebase we first want to make test 😉

@martinsoenen martinsoenen requested a review from GautierDele March 9, 2026 09:00
@martinsoenen
Copy link
Contributor Author

LGTM ! Can you just please force the PHP version we support in the composer.json file ? https://github.com/xefi/faker-php/blob/main/composer.json#L21

If PHP upgrades but breaks our codebase we first want to make test 😉

Done :D Thanks for the idea !

@martinsoenen martinsoenen merged commit 6af73df into main Mar 9, 2026
5 checks passed
@GautierDele GautierDele deleted the php8.5-compatibility branch March 9, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants