ssa: panic on static nil dereference#1890
Draft
cpunion wants to merge 3 commits into
Draft
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Update on Root cause:
Fix:
Local tests:
CI:
|
Collaborator
Author
|
Update for
Local validation:
CI after push is triggered and currently queued/pending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/goassignment-order coverage for RHS-before-map-insert and multiple assignment map update before later nil storefixedbugs/issue22881.goandfixedbugs/issue23017.goNotes
test/go/assignment_order_test.go. A fullllgo test ./test/gopackage build is currently blocked by an existing unrelated generic-local-type link error; the new file was run directly underllgo test.Targeted commands
go test ./test/goroot -run TestGoRootRunCases/fixedbugs/issue22881.go -count=1 -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/issue22881\.go$' -xfail /tmp/llgo-no-xfail.yaml -run-timeout 30stimed out inllgo run.go test ./test/go -count=1timeout 90s go run ./cmd/llgo test -run 'TestMapUpdateRHSNilDerefOrder|TestMultipleAssignmentMapUpdateBeforeNilStore' ./test/go/assignment_order_test.gogo test ./ssa -count=1go test ./cl -run TestCompileLargeNilDerefInterfaceGuards -count=1go test ./test/goroot -run TestGoRootRunCases/fixedbugs/issue22881.go -count=1 -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/issue22881\.go$' -xfail /tmp/llgo-no-xfail.yaml -run-timeout 30sgo test ./test/goroot -run TestGoRootRunCases/fixedbugs/issue23017.go -count=1 -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/issue23017\.go$' -xfail /tmp/llgo-no-xfail.yaml -run-timeout 30sgo test ./test/goroot -run TestGoRootRunCases -count=1 -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/(issue22881|issue23017)\.go$' -run-timeout 30s