Fix ArgumentException by making enum parsing case-insensitive #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: p1xel8ted <10510767+p1xel8ted@users.noreply.github.com>
Co-authored-by: p1xel8ted <10510767+p1xel8ted@users.noreply.github.com>
…um-issue Make Enum.Parse case-insensitive to fix ArgumentException on save load
|
@p1xel8ted is attempting to deploy a commit to the hayper's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Download the artifacts for this pull request: |
Collaborator
|
would "using System" be redundant? |
Contributor
I checked, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several files to improve the robustness of enum parsing by making it case-insensitive, and adds missing
using System;directives where necessary. The main changes ensure that string values can be parsed into their respective enums regardless of letter casing, which helps prevent runtime errors due to case mismatches.Enum parsing improvements:
Enum.Parsecalls to include theignoreCase: trueparameter, making enum parsing case-insensitive inCustomSkinManager.cs,KeyCodes.cs, andSettingsPatches.cs. [1] [2] [3]Code quality and consistency:
using System;directives to files that use enums and parsing, ensuring necessary namespaces are included inCustomSkinManager.cs,KeyCodes.cs, andSettingsPatches.cs. [1] [2] [3]