bitwriter_grow_() correctly test for out-of-legit-range values#862
Closed
DEATH923 wants to merge 2 commits intoxiph:masterfrom
Closed
bitwriter_grow_() correctly test for out-of-legit-range values#862DEATH923 wants to merge 2 commits intoxiph:masterfrom
DEATH923 wants to merge 2 commits intoxiph:masterfrom
Conversation
added 2 commits
December 22, 2025 11:27
… maximum possible padding of 0xFFFFFF bytes to be written
Collaborator
|
I'll need to split this up |
Author
|
Sorry, it obviously wasn't my intention to add second commit to the PR. Thanks for splitting & merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current libFLAC fails to write maximum possible padding value of 0xFFFFFF because of incorrect range check in bitwriter_grow_().
This commit addresses the issue.