Open
Conversation
Contributor
|
You hit the delete or backspace key a little too much resulting in |
Contributor
|
Simplified / cleaned up patch: |
Author
|
@sezero Hi, has your patch been merged into the repo? |
Contributor
No. I just added my comments here to notify you of the issues in your patch, that's all. |
Contributor
|
Further research suggests it's only API levels 21, 22, and 23 which were broken. Prior to that the defines were just ignored by the NDK. |
Contributor
|
Actually, this also depends on the ndk version. |
rillian
added a commit
that referenced
this pull request
Apr 11, 2025
Apparently requesting 64-bit file support on Android api versions prior to 24 results in missing `ftello()` and `fseeko()` declarations and other problems. The idea of this fix is to just limit such builds to 32-bit files. Change contributed by Vy Nguyen, originally in #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immediate symptom is that in src/stream.c, declarations for
ftello(...)andfseeko(...)are not available.(Errors will be raised if compiled with
-Wimplicit-function-declaration