Hide full search speed setting from public api#2846
Open
KyleSiefring wants to merge 1 commit intoxiph:masterfrom
Open
Hide full search speed setting from public api#2846KyleSiefring wants to merge 1 commit intoxiph:masterfrom
KyleSiefring wants to merge 1 commit intoxiph:masterfrom
Conversation
lu-zero
requested changes
Nov 5, 2021
Collaborator
lu-zero
left a comment
There was a problem hiding this comment.
why do you want it hidden and why aren't you just making the field pub(crate)?
Collaborator
Author
|
Mostly want it hidden so that I can add and remove it without multiple api changes. I felt that using pub(crate) might end up being too error prone. Example: accidentally exposing things by writing pub instead of pub(crate). One alternative would be to save the speed level and seed internal settings inside the encoder, but not inside api exposed structures. |
Collaborator
|
Until I cut a release any API you put move or change is fine and expected to change. I'll make sure that the non-exhaustive and default() is in place tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoughts?