Update save and load settings functions#2
Open
drakbar wants to merge 1 commit intoxposure:masterfrom
drakbar:patch-2
Open
Update save and load settings functions#2drakbar wants to merge 1 commit intoxposure:masterfrom drakbar:patch-2
drakbar wants to merge 1 commit intoxposure:masterfrom
drakbar:patch-2
Conversation
drakbar
commented
Mar 7, 2017
drakbar
commented
- added directive System.IO.
- passed ImGuiState as a parameter to SaveSettings which changes line
- in LoadSettings the blocks for loading position and size are almost identical, a lambda might be a better approach
- made Shutdown public In order for SaveSettings to be called
- the game crashes when trying to double click the window to collapse it and if you change the value of collapse in the ini file to True. the program crashes at line 3963 in ImGui.cs
1) added directive System.IO. 2) passed ImGuiState as a parameter to SaveSettings which changes line 3) in LoadSettings the blocks for loading position and size are almost identical, a lambda might be a better approach 4) made Shutdown public In order for SaveSettings to be called 5) the game crashes when trying to double click the window to collapse it and if you change the value of collapse in the ini file to True. the program crashes at line 3963 in ImGui.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.