Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings December 5, 2025 16:04
@GrigoriyPA GrigoriyPA requested review from a team as code owners December 5, 2025 16:04
@GrigoriyPA GrigoriyPA requested review from APozdniakov and removed request for Copilot December 5, 2025 16:04
@ydbot
Copy link
Collaborator

ydbot commented Dec 5, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

🔴 2025-12-05 16:07:27 UTC The validation of the Pull Request description has failed. Please update the description.

Only one category can be selected at a time.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

2025-12-05 16:07:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e4a069 has started.
2025-12-05 16:07:33 UTC Artifacts will be uploaded here
2025-12-05 16:08:54 UTC ya make is running...
🟡 2025-12-05 17:39:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40189 37260 0 5 2902 22

2025-12-05 17:39:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-12-05 17:49:47 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
46 (only retried tests) 33 0 0 0 13

🟢 2025-12-05 17:49:54 UTC Build successful.
🟢 2025-12-05 17:50:13 UTC ydbd size 2.3 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1d6c232 merge: 7e4a069 diff diff %
ydbd size 2 466 152 008 Bytes 2 466 156 392 Bytes +4.3 KiB +0.000%
ydbd stripped size 524 843 136 Bytes 524 844 288 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

2025-12-05 16:07:43 UTC Pre-commit check linux-x86_64-release-asan for 7e4a069 has started.
2025-12-05 16:08:01 UTC Artifacts will be uploaded here
2025-12-05 16:10:04 UTC ya make is running...
🟡 2025-12-05 17:23:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12460 12275 0 158 17 10

🟢 2025-12-05 17:23:27 UTC Build successful.
🟢 2025-12-05 17:23:52 UTC ydbd size 3.8 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1d6c232 merge: 7e4a069 diff diff %
ydbd size 4 127 809 296 Bytes 4 127 816 224 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 532 692 760 Bytes 1 532 695 192 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

auto curHopIndexModBuckets = curHopIndex % bucketsForKey.size();

if (curHopIndex > closeBeforeIndex) {
if (curHopIndex >= closeBeforeIndex) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оптимизация, не очень нужная, кмк

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

2025-12-09 12:25:39 UTC Pre-commit check linux-x86_64-release-asan for ddb9b59 has started.
2025-12-09 12:26:18 UTC Artifacts will be uploaded here
2025-12-09 12:28:12 UTC ya make is running...
🟡 2025-12-09 13:48:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12773 12665 0 93 7 8

🟢 2025-12-09 13:49:09 UTC Build successful.
🟡 2025-12-09 13:49:33 UTC ydbd size 3.8 GiB changed* by +106.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2924eb2 merge: ddb9b59 diff diff %
ydbd size 4 131 603 280 Bytes 4 131 712 712 Bytes +106.9 KiB +0.003%
ydbd stripped size 1 533 705 176 Bytes 1 533 750 168 Bytes +43.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

2025-12-09 12:28:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for ddb9b59 has started.
2025-12-09 12:28:55 UTC Artifacts will be uploaded here
2025-12-09 12:31:03 UTC ya make is running...
🟡 2025-12-09 14:12:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40533 37609 0 4 2902 18

2025-12-09 14:12:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-12-09 14:22:11 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40 (only retried tests) 28 0 0 0 12

🟢 2025-12-09 14:22:18 UTC Build successful.
🟢 2025-12-09 14:22:43 UTC ydbd size 2.3 GiB changed* by +62.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2924eb2 merge: ddb9b59 diff diff %
ydbd size 2 467 238 480 Bytes 2 467 302 408 Bytes +62.4 KiB +0.003%
ydbd stripped size 525 062 560 Bytes 525 077 824 Bytes +14.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants