Use using for scoped spies

[cameronapak]

Summary

Use using for scoped Vitest spies so cleanup happens automatically when the test block exits.

Inspired by: https://x.com/sebastienlorber/status/2057033638827483236

Testing

• pnpm --filter @youversion/platform-core test -- StorageStrategy.test.ts languages.test.ts Users.test.ts
• pnpm --filter @youversion/platform-react-ui test -- bible-version-picker.test.tsx

[changeset-bot]

⚠️ No Changeset found

Latest commit: 057dfbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR