feat(ui): add onFootnotePress callback to BibleCard

[Dustin-Kelley]

Summary

• Add optional onFootnotePress to BibleCardProps and forward it to the internal BibleTextView
• Add unit test that clicks a footnote marker and asserts callback payload
• Changeset for patch release of @youversion/platform-react-ui

Test plan

• pnpm test bible-card.test.tsx in packages/ui
• Consumer: platform-sdk-reactnative-expo links built package and verifies footnote sheet on dev client

Made with Cursor

Greptile Summary

This PR adds an optional onFootnotePress callback to BibleCard, mirroring the existing pattern from BibleReader, and threads it through to the internal BibleTextView. When provided, the callback replaces the built-in popover with a consumer-controlled handler receiving FootnoteData (verseNum, notes, verseHtml, reference).

• bible-card.tsx: Adds onFootnotePress?: (data: FootnoteData) => void to BibleCardProps, destructures it in BibleCard, and forwards it to BibleTextView.
• bible-card.test.tsx: New describe block renders a passage with a raw footnote span, waits for the footnote button, clicks it, and asserts the full FootnoteData payload including verseNum, reference, and the notes array content.
• .changeset/bible-card-footnote-press.md: Changeset correctly marked as minor for the new optional public API addition.

Confidence Score: 5/5

Safe to merge — the change is additive and opt-in, with no modifications to existing behavior.

The new prop is optional and strictly additive: existing consumers who do not pass onFootnotePress continue to get the built-in Popover unchanged. The prop is already exported via FootnoteData in the package's public index, the test exercises the full click-to-callback path with payload assertions, and the changeset is correctly labeled minor.

No files require special attention.

Important Files Changed

Filename	Overview
packages/ui/src/components/bible-card.tsx	Adds optional onFootnotePress prop to BibleCardProps and forwards it to BibleTextView; change is minimal and follows the existing BibleReader pattern exactly.
packages/ui/src/components/bible-card.test.tsx	New test suite correctly uses waitFor + userEvent to verify the footnote button click calls onFootnotePress with the full FootnoteData payload including notes content.
.changeset/bible-card-footnote-press.md	Changeset correctly uses minor bump for the new optional public API prop.

Sequence Diagram

sequenceDiagram
    participant Consumer
    participant BibleCard
    participant BibleTextView
    participant VerseHtml as Verse.Html
    participant BibleTextHtml
    participant VerseFootnoteButton

    Consumer->>BibleCard: render with onFootnotePress
    BibleCard->>BibleTextView: passageState + onFootnotePress
    BibleTextView->>VerseHtml: html + onFootnotePress
    VerseHtml->>BibleTextHtml: transformedHtml + onFootnotePress
    BibleTextHtml->>BibleTextHtml: useLayoutEffect extracts footnote anchors
    BibleTextHtml->>VerseFootnoteButton: portal per anchor with onFootnotePress
    Note over VerseFootnoteButton: onFootnotePress present → plain button (no Popover)
    Consumer->>VerseFootnoteButton: click footnote button
    VerseFootnoteButton->>Consumer: "onFootnotePress({ verseNum, notes, verseHtml, reference })"

Loading

_{Reviews (3): Last reviewed commit: "fix(ui): address greptile review feedbac..." | Re-trigger Greptile}

[changeset-bot]

🦋 Changeset detected

Latest commit: 63ec262

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@youversion/platform-react-ui	Minor
vite-react	Patch
@youversion/platform-core	Minor
@youversion/platform-react-hooks	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[cameronapak]

LGTM