Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"@types/node": "25.5.0",
"@types/rimraf": "4.0.5",
"@types/validate-npm-package-name": "4.0.2",
"@typescript-eslint/eslint-plugin": "8.57.1",
"@typescript-eslint/parser": "8.57.1",
"@typescript-eslint/eslint-plugin": "8.57.2",
"@typescript-eslint/parser": "8.57.2",
"codependence": "0.3.1",
"eslint": "10.1.0",
"eslint-config-prettier": "10.1.8",
Expand All @@ -66,7 +66,7 @@
"tsup": "8.5.1",
"tsutils": "^3.21.0",
"tsx": "^4.7.0",
"typescript": "5.9.3",
"typescript": "6.0.2",
"typescript-eslint": "^7.7.1"
Comment on lines +69 to 70
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 TypeScript 6.x violates @typescript-eslint peer dependency constraints

The @typescript-eslint/eslint-plugin@8.57.2, @typescript-eslint/parser@8.57.2, and related packages (@typescript-eslint/project-service, @typescript-eslint/tsconfig-utils, @typescript-eslint/typescript-estree, @typescript-eslint/type-utils) all declare a peer dependency of typescript: '>=4.8.4 <6.0.0' (visible in pnpm-lock.yaml). TypeScript 6.0.2 is outside this supported range.

Similarly, typescript-eslint@^7.7.1 (resolved to 7.18.0) and tsutils@^3.21.0 also have similar constraints.

This peer dependency mismatch means:

  • pnpm will emit unsatisfied peer dependency warnings at install time
  • ESLint's type-aware linting rules may produce incorrect results or fail outright, since the @typescript-eslint AST parser is not guaranteed to work with TypeScript 6.x's compiler API
  • The typecheck and lint CI steps are at risk of producing false negatives

To resolve this, the @typescript-eslint packages should be upgraded to a version that explicitly supports TypeScript 6.x (likely @typescript-eslint/* v8.58+ or the typescript-eslint v8 meta-package), or TypeScript should remain at the latest 5.x release until the linting toolchain catches up.

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 69-70

Comment:
**TypeScript 6.x violates `@typescript-eslint` peer dependency constraints**

The `@typescript-eslint/eslint-plugin@8.57.2`, `@typescript-eslint/parser@8.57.2`, and related packages (`@typescript-eslint/project-service`, `@typescript-eslint/tsconfig-utils`, `@typescript-eslint/typescript-estree`, `@typescript-eslint/type-utils`) all declare a peer dependency of `typescript: '>=4.8.4 <6.0.0'` (visible in `pnpm-lock.yaml`). TypeScript 6.0.2 is outside this supported range.

Similarly, `typescript-eslint@^7.7.1` (resolved to `7.18.0`) and `tsutils@^3.21.0` also have similar constraints.

This peer dependency mismatch means:
- pnpm will emit unsatisfied peer dependency warnings at install time
- ESLint's type-aware linting rules may produce incorrect results or fail outright, since the `@typescript-eslint` AST parser is not guaranteed to work with TypeScript 6.x's compiler API
- The `typecheck` and `lint` CI steps are at risk of producing false negatives

To resolve this, the `@typescript-eslint` packages should be upgraded to a version that explicitly supports TypeScript 6.x (likely `@typescript-eslint/*` v8.58+ or the `typescript-eslint` v8 meta-package), or TypeScript should remain at the latest 5.x release until the linting toolchain catches up.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

},
"keywords": [
Expand Down
Loading
Loading