versus workflows: Update existing PR if any instead of closing/opening#240
versus workflows: Update existing PR if any instead of closing/opening#240thc202 merged 2 commits intozapbot:masterfrom
Conversation
|
This will not work as intended, the step I'd also prefer that we don't fail the workflow when the PR is just being updated, there's no reason to and just creates noise (still getting one each day). |
|
I'll look at the first point. (or |
|
I updated the juiceshop workflow, does that address your first concern? |
6d6604a to
9e5b266
Compare
|
Seems so, it's no longer pushing the latest from upstream. |
|
And which option for the failures or do you have another idea? |
|
I don't mind which way as long as it only fails if there's an actual failure (to create the PR or push the changes). |
|
In that case it would require something more like exit code logic, but I'm not sure they get specific enough. For the time being, let's narrow this PR down to adjusting the PR logic in other workflows. Then I can look at the failure logic in another? |
|
I'm fine with that, there aren't other ongoing PRs so failures should be minimal. |
|
All adjusted. |
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates multiple GitHub Actions workflows that publish scan/auth results to zaproxy/zaproxy-website so repeated runs update the same branch/PR rather than creating new PRs each time.
Changes:
- Removes the explicit “sync fork branch to upstream/main” steps from the
zap-vs-*workflows. - Pushes results to a fixed branch name with force push and attempts
gh pr create --fill, ignoring failures (intended to no-op when the PR already exists). - Aligns
auth-tests.ymlPR creation behavior with the “attempt create, ignore failure” approach.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/zap-vs-webseclab.yml | Updates PR-raising step to force-push a fixed branch and attempt PR creation without failing if it already exists. |
| .github/workflows/zap-vs-wavsep.yml | Same PR update behavior for wavsep results. |
| .github/workflows/zap-vs-ssti.yml | Same PR update behavior for SSTI results. |
| .github/workflows/zap-vs-owasp-benchmark.yml | Same PR update behavior for OWASP Benchmark results. |
| .github/workflows/zap-vs-juiceshop.yml | Same PR update behavior for Juice Shop results. |
| .github/workflows/zap-vs-firingrange.yml | Same PR update behavior for Firing Range results. |
| .github/workflows/zap-vs-crawlmaze.yml | Same PR update behavior for Crawl Maze results. |
| .github/workflows/auth-tests.yml | Switches to `gh pr create --fill |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4ba6ebe to
e44c20c
Compare
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
|
Thank you! |
Similar to the recent auth-tests addition.