Conversation
|
For the website PRs the DCO on the commits is enough. |
|
We can consider it preemptive in case I make other contributions in the future elsewhere |
|
I'm not sure there's the need but If you want you should to it properly, see |
|
I'm not sure what that means. I followed the instructions in this repo's README. |
|
That's wrong, we don't have the CLA enabled here but we can do I guess. |
|
It seems to be correct. Bottom of the README here says: "If you would like to agree to the ZAP CLA but do not have a PR ready to submit to the ZAP repos then you can submit a dummy one to this repo - we don't need the PR to be merged so can then just close it." That is what I did, using the verbatim text for agreement in the PR body, as would be used elsewhere to agree to the CLA. |
|
I appear to be the only one who's done that so far tho lol |
|
@thc202 Why is this reopened? |
|
Don't you want to sign the CLA? |
I thought posting this initial message was the required maneuver to do so, what else do I need to do? |
|
no problem, lmk |
|
Can you try push again? |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |

I have read the CLA Document and I hereby sign the CLA